Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deprecation] 'ColorizedTextReporter' only accepts 'ColorMappingDict' #8464

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
🔨 Refactoring

Description

Enacting of planned deprecations.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Mar 20, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.0a6 milestone Mar 20, 2023
DanielNoord
DanielNoord previously approved these changes Mar 20, 2023
doc/whatsnew/fragments/8464.internal Outdated Show resolved Hide resolved
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) March 20, 2023 20:54
@Pierre-Sassoulas Pierre-Sassoulas changed the title [deprecation] 'ColorizedTextReporter' only accept 'ColorMappingDict' [deprecation] 'ColorizedTextReporter' only accepts 'ColorMappingDict' Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #8464 (65076dd) into main (9488c8c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8464      +/-   ##
==========================================
+ Coverage   95.73%   95.76%   +0.03%     
==========================================
  Files         174      174              
  Lines       18396    18366      -30     
==========================================
- Hits        17612    17589      -23     
+ Misses        784      777       -7     
Impacted Files Coverage Δ
pylint/reporters/text.py 94.44% <100.00%> (+4.73%) ⬆️

... and 1 file with indirect coverage changes

@Pierre-Sassoulas Pierre-Sassoulas merged commit 699ac88 into pylint-dev:main Mar 20, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the remove-deprecated-handling-of-dict-in-color-reporter branch March 20, 2023 21:44
@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 65076dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants