[deprecation] setup.cfgand tox.ini sections need to start by 'pylint'
#8465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
Maintenance
| @@ -41,23 +40,13 @@ def _parse_ini_file(self, file_path: Path) -> tuple[dict[str, str], list[str]]: | |||
|
|
|||
| config_content: dict[str, str] = {} | |||
| options: list[str] = [] | |||
| ini_file_with_sections = self._ini_file_with_sections(file_path) | |||
There was a problem hiding this comment.
There's a perf increase here, we calculate the boolean once instead of for each sections 😄
DanielNoord
previously approved these changes
Mar 20, 2023
Pierre-Sassoulas
changed the title
setup.cfgand tox.ini sections need to start by 'pylint'
mbyrnepr2
reviewed
Mar 20, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8465 +/- ##
==========================================
- Coverage 95.73% 95.73% -0.01%
==========================================
Files 174 174
Lines 18373 18371 -2
==========================================
- Hits 17589 17587 -2
Misses 784 784
|
Co-authored-by: Mark Byrne <31762852+mbyrnepr2@users.noreply.github.com>
mbyrnepr2
approved these changes
Mar 20, 2023
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 8d2ead2 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Enacting planned deprecations.