[base checker] Fix the ordering of checkers for extensions #8956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Maintenance
The comparison was not done properly for extension when the second values given was a builtin and the first one an extension. The tests were not testing this case properly because the alphabetical order made us think that everything went right. Added a test with a low value extension checker. Necessary for pylint-dev#8951
Pierre-Sassoulas
force-pushed
the
fix-checkers-sorting
branch
from
2dc5b47
to
34c1139
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8956 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 173 173
Lines 18557 18558 +1
=======================================
+ Hits 17767 17768 +1
Misses 790 790
|
This was referenced Aug 15, 2023
DanielNoord
reviewed
Aug 15, 2023
pylint/checkers/base_checker.py
Outdated
| if not isinstance(other, BaseChecker): | ||
| # print(f"{other} is not a base checker.") |
There was a problem hiding this comment.
Quite a bit of debug statement?
There was a problem hiding this comment.
I could turn that into comments, but then we'd need to transform it in debug statement again if there's a problem in the future π
There was a problem hiding this comment.
Hmm I think we could remove them here. This feels a bit weird to me
There was a problem hiding this comment.
Yeah true, comments explaining what the code is doing are bad form. (xor operator that makes it necessary must be bad form too π )
DanielNoord
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
The comparison was not done properly for extension when the second values given was a builtin and the first one an extension. The tests were not testing this case properly because the alphabetical order made us think that everything went right. Added a test with a low alphabetical value extension checker.
Necessary for #8951