Add tests for existing Pyreverse bugs #8983
Conversation
nickdrozd
added
the
Skip news π
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8983 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 173 173
Lines 18604 18604
=======================================
Hits 17815 17815
Misses 789 789
|
|
BTW, I have fixes for all of these. The logical error is the same, but implemented in three different ways. Should they go up in one PR or in three separate PRs? Or just push straight to this one? |
|
Ha I thought you just wanted to add the tests. Well if you have the fixes how about creating 3 PRs and fixing at the same time as adding the relevant tests? Feels clearer if we need to check the git history / PR later imo. |
|
The behaviors and changes involved are subtly different, so I think separating everything will help to make clear exactly what is affected by what. So if the tests for the buggy behavior are set up first, then the commits with the changes will show the changes to that behavior. |
|
Added a test for #8671 |
There was a problem hiding this comment.
Sounds like a good plan to better understand the following PRs and changes in behaviour.
One heads up for the added sorted call:
#8776
We discussed if this is a wanted behavior or not, and ended with saying it would probably be best to add a command line switch to enable/disable sorting.
But that's a different topic, and as we already sort other stuff I'm totally fine with adding the sorted call here as well.
* Add Pyreverse bug tests * Sort Pyreverse class diagram names * Add test for bad line break (cherry picked from commit 1427461)
Type of Changes
Description
Add tests for existing bugs:
pyreverseshould ignore class level attribute declarationsΒ #8189Running the last of these tests successfully requires adding a
sortcall, which is an extremely minor change in behavior.