Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pyreverse duplicate annotations #9012

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

nickdrozd
Copy link
Collaborator

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #8888

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #9012 (36970a5) into main (77dcaad) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9012   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files         173      173           
  Lines       18648    18648           
=======================================
  Hits        17856    17856           
  Misses        792      792           
Files Changed Coverage Ξ”
pylint/pyreverse/diagrams.py 93.22% <100.00%> (ΓΈ)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 36970a5

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘Œ

Copy link
Collaborator

@DudeNr33 DudeNr33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DudeNr33 DudeNr33 merged commit fbbf788 into pylint-dev:main Sep 7, 2023
50 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
Pierre-Sassoulas pushed a commit that referenced this pull request Sep 7, 2023
(cherry picked from commit fbbf788)

Co-authored-by: Nick Drozd <nicholasdrozd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported Bug πŸͺ² pyreverse Related to pyreverse component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type reported by pyreverse for unions and generics
3 participants