Fix Pyreverse duplicate arrows bug #9029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
pyreverse
|
The logic is similar to #9004. Rather than pulling in all annotated fields and all local assignments, we pull in the annotated fields and then only pull in those local assignments that haven't already been seen |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9029 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 173 173
Lines 18648 18652 +4
=======================================
+ Hits 17856 17860 +4
Misses 792 792
|
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 809d391 |
Pierre-Sassoulas
approved these changes
Sep 12, 2023
DudeNr33
approved these changes
Sep 16, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2023
(cherry picked from commit 3f93f1e)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #8522