Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[used-before-assignment] Fix FP for try/else/continue #9374

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #6804

@jacobtylerwalls jacobtylerwalls added False Positive 🦟 A message is emitted but nothing is wrong with the code backport maintenance/3.2.x labels Jan 21, 2024
@jacobtylerwalls jacobtylerwalls added this to the 3.0.4 milestone Jan 21, 2024
@jacobtylerwalls jacobtylerwalls added the C: used-before-assignment Issues related to 'used-before-assignment' check label Jan 21, 2024
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (81bd39a) 95.81% compared to head (b9e410a) 95.81%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9374   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         173      173           
  Lines       18769    18772    +3     
=======================================
+ Hits        17983    17986    +3     
  Misses        786      786           
Files Coverage Ξ”
pylint/checkers/variables.py 97.38% <100.00%> (+<0.01%) ⬆️

This comment has been minimized.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>

This comment has been minimized.

Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit b9e410a

@jacobtylerwalls jacobtylerwalls merged commit 7d0c7ac into main Jan 22, 2024
44 checks passed
@jacobtylerwalls jacobtylerwalls deleted the 6804-uba-continue branch January 22, 2024 17:02
github-actions bot pushed a commit that referenced this pull request Jan 22, 2024
Pierre-Sassoulas pushed a commit that referenced this pull request Jan 22, 2024
(cherry picked from commit 7d0c7ac)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported C: used-before-assignment Issues related to 'used-before-assignment' check False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive used-before-assignment with try/else/continue
2 participants