Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch ValueError - generator already executing #9454

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Feb 22, 2024

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Overwrite sys.unraisablehook to catch ValueError - "generator already executing" messages for Python 3.12.0 - 3.12.2 only. This is fixed upstream in both 3.12.3 and 3.13a2+.

Closes #9138

@cdce8p cdce8p added Upstream Bug πŸͺ² Bug in a dependency of pylint that is not astroid python 3.12 backport maintenance/3.2.x labels Feb 22, 2024
@cdce8p cdce8p added this to the 3.0.4 milestone Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.81%. Comparing base (6d3e6a9) to head (ee4d103).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9454   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         173      173           
  Lines       18788    18792    +4     
=======================================
+ Hits        18001    18005    +4     
  Misses        787      787           
Files Coverage Ξ”
pylint/__init__.py 97.05% <100.00%> (+0.18%) ⬆️

... and 1 file with indirect coverage changes

This comment has been minimized.

Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit ee4d103

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘Œ

@cdce8p cdce8p merged commit d4f0ef7 into pylint-dev:main Feb 22, 2024
44 checks passed
@cdce8p cdce8p deleted the catch-valueerror branch February 22, 2024 23:19
github-actions bot pushed a commit that referenced this pull request Feb 22, 2024
Pierre-Sassoulas pushed a commit that referenced this pull request Feb 22, 2024
(cherry picked from commit d4f0ef7)

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported python 3.12 Upstream Bug πŸͺ² Bug in a dependency of pylint that is not astroid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 - ValueError: generator already executing
3 participants