Fix false negative for property-with-parameters
#9592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦rameters which are ``positional-only``, ``keyword-only``, ``variadic positional`` or ``variadic keyword``. Closes pylint-dev#9584
mbyrnepr2
added
the
False Negative π¦
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9592 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 173 173
Lines 18825 18825
=======================================
Hits 18038 18038
Misses 787 787
|
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
previously approved these changes
May 3, 2024
Sure let me make that change a little later before we merge(currently sitting in my car in the pouring Dutch rain while my daughter is napping in the back π) |
check and regenerate the functional tests.
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 491375d |
Pierre-Sassoulas
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix false negative for
property-with-parametersin the case of parameters which arepositional-only,keyword-only,variadic positionalorvariadic keyword.Closes #9584