Avoid search paths for ImportChecker when possible #9595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If possible it is desirable to look for modules with no context file as it results in no search paths being given to astroid's find_spec(). This makes calls to it more uniform and opens up the possibility of effective caching. Refs pylint-dev#9310.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9595 +/- ##
=======================================
Coverage 95.81% 95.82%
=======================================
Files 173 173
Lines 18825 18831 +6
=======================================
+ Hits 18038 18044 +6
Misses 787 787
|
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
previously approved these changes
May 4, 2024
I think the cache is needed in astroid but from a pylint point of view then yes, this is probably all that can be done on pylint to fix the issue. |
crazybolillo
force-pushed
the
i9310-crazybolillo
branch
from
bb3297b
to
ab5bafd
Compare
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit ab5bafd |
jacobtylerwalls
approved these changes
May 4, 2024
|
Great ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If possible it is desirable to look for modules with no context file as it results in no search paths being given to astroid's find_spec(). This makes calls to it more uniform and opens up the possibility of effective caching.
Refs #9310.
Type of Changes