[symilar] Fix the short form options that weren't being processed properly #9709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Crash π₯
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
force-pushed
the
fix-symilar-crash
branch
from
c45401f
to
b310d3f
Compare
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9709 +/- ##
=======================================
Coverage 95.84% 95.85%
=======================================
Files 174 174
Lines 18865 18873 +8
=======================================
+ Hits 18082 18090 +8
Misses 783 783
|
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit e798aca |
DanielNoord
reviewed
Jun 7, 2024
| @@ -497,3 +497,32 @@ def test_set_duplicate_lines_to_zero() -> None: | |||
| similar.Run(["--duplicates=0", SIMILAR1, SIMILAR2]) | |||
| assert ex.value.code == 0 | |||
| assert output.getvalue() == "" | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("v", ["d"]) | |||
There was a problem hiding this comment.
This seems unnecessary?
There was a problem hiding this comment.
Yes, but with argparse we'll be able to do both again.
DanielNoord
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #9343, follow-up to migrate to a more "2010" way of doing things in #9710