Fix a crash when a pylint must display unicode raising a UnicodeEncodeError #9732
+32
β3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Work in progress
Crash π₯
|
We should probably aim to keep the |
|
|
| @@ -0,0 +1 @@ | |||
| comparison-of-constants:3:7:3:37::"Comparison between constants: 'π == ' has a constant value":HIGH | |||
There was a problem hiding this comment.
Suggested change
| comparison-of-constants:3:7:3:37::"Comparison between constants: 'π == ' has a constant value":HIGH | |
| comparison-of-constants:3:7:3:37::"Comparison between constants: '"\U00010000" == "\ud800\udc00"' has a constant value":HIGH |
Imo we should aim for this, but I have an intuition that the ast module internal might be involved.
There was a problem hiding this comment.
Yes, but I don't think we can. self.out is utf-8 encoded so we always need to encode/escape to utf-8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Work in progress for #8736, this is probably not the right fix, but it's a fix. Hoping for a surrogates/unicode expert to chime in with the right approach π !