Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-destructing cookies not working? #245

Closed
ghost opened this issue Mar 15, 2017 · 8 comments
Closed

Self-destructing cookies not working? #245

ghost opened this issue Mar 15, 2017 · 8 comments

Comments

@ghost
Copy link

ghost commented Mar 15, 2017

Firefox 52.0
macOS 10.12.3
Self-Destructing Cookies 0.4.11

"Grace period" for cookie deletion is set to 1 second after the tab is closed. Worked perfectly on a clean new Firefox profile.
Some settings in user.js seem to override this, cookies are only deleted after closing Firefox.

Any ideas?

@Atavic
Copy link

Atavic commented Mar 15, 2017

Network.cookie.lifetimePolicy is 2, but here is said

Self-Destructing Cookies Configuration:
Keep network.cookie.lifetimePolicy = 0

@ghost
Copy link
Author

ghost commented Mar 15, 2017

Keep network.cookie.lifetimePolicy = 0

Thanks! Unfortunately, that didn't work.
Even tried this on a clean new profile with only user.js and SDC-Addon installed, still nothing. Strange.

@Atavic
Copy link

Atavic commented Mar 15, 2017

user_pref("network.cookie.thirdparty.sessionOnly", true); try reverting this one also.

@ghost
Copy link
Author

ghost commented Mar 16, 2017

Still the same.

I just noticed that the SDC Icon in the top right corner completely disappears, you cant even get it back via the "3 stripes" button.
Same goes for the menu entries under "Tools".

@Thorin-Oakenpants
Copy link

Thorin-Oakenpants commented Mar 16, 2017

Are you using FPI? No, its not set by this user.js, but I'm asking. Because FP isolation will break CSP (and other cookie controlling addons, and cache and storage access)

check privacy.firstparty.isolate -> false

Also, this js will open in PB mode. I have no idea what PB mode does to override cookie settings (i think all it does is enforce session only). Does SDC cookies work if you open>normal window from the menu?

EDIT:

  • Have you tested this is a vanilla default FF. First test SDC works (don't add any other add-ons) - check "Worked perfectly on a clean new Firefox profile."
  • Then add the user.js and re-test.

So just to clarify, the only settings changed are those done by this repo's user.js?

@ghost
Copy link
Author

ghost commented Mar 16, 2017

check privacy.firstparty.isolate -> false

It is set to false, yes.

So just to clarify, the only settings changed are those done by this repo's user.js?

I made a clean new profile, only added SDC. Cookie deletion works perfectly. Closed Firefox, added user.js, opened Firefox -> doesn't work anymore + SDC icons are gone.

Also, this js will open in PB mode. I have no idea what PB mode does to override cookie settings (i think all it does is enforce session only). Does SDC cookies work if you open>normal window from the menu?

This seems to be the issue! Thanks!
When I turn off PB on autostart inside user.js (browser.privatebrowsing.autostart -> false) SDC works again and the icons are there again, too.

So Private Browsing Mode does seem to break Self-Destructing Cookies.
Should I report this to the dev of the addon? Or do you think he is aware of that?

EDIT:
Dev is aware of the issue. He can do nothing about it, according to this.

@Atavic
Copy link

Atavic commented Mar 16, 2017

Cookies aren't saved in Private Browsing, so there are none to be destroyed. All Session Cookies are deleted when exiting Private Browsing Mode.

@nodiscc
Copy link
Contributor

nodiscc commented Mar 17, 2017

@Atavic the second part is correct "All Session Cookies are deleted when exiting Private Browsing Mode".

The first part is not ("Cookies aren't saved in Private Browsing"). Firefox maintains a private cookie jar (first-party only as per user.js settings). As stated in SDC's FAQ the addon is unable to access this cookie jar, hence SDC does not work in Private Browsing.

If you want SDC to be able to do what it's designed for (delete cookies after a set amount of time after closing a site's tabs), you have to disable private browsing

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants