Coerce ints to floats

pylon · May 8, 2019 · 2eaea08 · 2eaea08
1 parent 048883d
commit 2eaea08
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/lib/spect.ex b/lib/spect.ex
@@ -187,10 +187,10 @@ defmodule Spect do
 
   # float
   defp to_type!(data, _module, :float, _args) do
-    if is_float(data) do
-      data
-    else
-      raise(ConvertError, "expected: float, found: #{inspect(data)}")
+    cond do
+      is_float(data) -> data
+      is_integer(data) -> data / 1.0
+      true -> raise(ConvertError, "expected: float, found: #{inspect(data)}")
     end
   end
 

diff --git a/mix.exs b/mix.exs
@@ -6,7 +6,7 @@ defmodule Spect.MixProject do
     [
       app: :spect,
       name: "Spect",
-      version: "0.3.0",
+      version: "0.3.1",
       elixir: "~> 1.7",
       elixirc_paths: elixirc_paths(Mix.env()),
       description: "Type specification extensions for Elixir.",

diff --git a/test/spect_test.exs b/test/spect_test.exs
@@ -63,7 +63,8 @@ defmodule Spect.Test do
     {:error, %ConvertError{}} = to_spec("invalid", Specs, :basic_integer)
 
     assert to_spec(1.0, Specs, :basic_float) === {:ok, 1.0}
-    {:error, %ConvertError{}} = to_spec(1, Specs, :basic_float)
+    assert to_spec(1, Specs, :basic_float) === {:ok, 1.0}
+    {:error, %ConvertError{}} = to_spec("1", Specs, :basic_float)
 
     assert to_spec(1.0, Specs, :basic_number) === {:ok, 1.0}
     assert to_spec(1, Specs, :basic_number) === {:ok, 1}