Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP syntax highlighting #102

Closed
xorbetto opened this issue Aug 24, 2019 · 2 comments
Closed

PHP syntax highlighting #102

xorbetto opened this issue Aug 24, 2019 · 2 comments
Milestone

Comments

@xorbetto
Copy link

Hello,
I've some problem using syntax highlighting on PHP code.
To make it work I've made some changes to file /plugins-client/lib.ace/www/mode/mode-php.js

this.tokenRe = new RegExp("^["
        + unicode.L
        + unicode.Mn + unicode.Mc
        + unicode.Nd
        + unicode.Pc + "\_]+", "g"
    );
    
this.nonTokenRe = new RegExp("^(?:[^"
        + unicode.L
        + unicode.Mn + unicode.Mc
        + unicode.Nd
        + unicode.Pc + "\_]|\s])+", "g"
    );

maybe some changes in unicode package.

@exsilium
Copy link
Collaborator

Hi @xorbetto ! Thanks for the report. The mode and theme files have been left in a stale state. In pyon directory please run:

make mode && make theme

Let me know if this fixes the php highlighting issue for you. Cheers 🍻

exsilium added a commit that referenced this issue Aug 27, 2019
@psociety
Copy link

I was having the same problem, doing the given command makes it work properly!

@exsilium exsilium added this to the v2.6.0 milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants