-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move metadata to pyproject.toml #236
Conversation
@nkoep Request for Review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks a lot for the PR! I've been meaning to get rid of the setup.cfg
file as well. I just added a bunch of pedantic style comments. If you don't mind, could you also change all indents to 2 spaces for consistency? 🙇
Hello @nkoep thanks a lot for the feedback. I addressed the requested changes in edda1b2. Looking forward to contributing more 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the swift updates! LGTM!
@nkoep Do you think we should try and add a |
I think this should be enough: diff --git a/pyproject.toml b/pyproject.toml
index bcb5f7e..5f885e4 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,5 +1,5 @@
[build-system]
-requires = ["pip==21.3.1", "setuptools==59.6.0", "setuptools-scm[toml]>=6.2"]
+requires = ["pip==22.3.1", "setuptools==65.6.3", "setuptools-scm[toml]>=6.2"]
build-backend = "setuptools.build_meta" Feel free to add it to this PR. |
Can I add
|
pyproject.toml
is the new standard for packaging python packages (first introduced in PEP 518 and later expanded in PEP 517, PEP 621 and PEP 660). This PR proposes to switch the metadata declaration from the legacysetup.cfg
in favour ofpyproject.toml
. This would also allow for a better minimal project structure.