Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow scipy>=1.13 #270

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Allow scipy>=1.13 #270

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8671e79
allow scipy>=1.13
kalekundert May 15, 2024
d6bbca6
require up-to-date setuptools
kalekundert May 15, 2024
727956f
update pinned version of setuptools used for CI
kalekundert May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/run_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ jobs:
- "3.8"
- "3.9"
- "3.10"
- "3.11"
- "3.12"
- "3.x"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does 3.x mean, and why do you need it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.x does not pass. Can you remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.x means "the most recent version of python". Right now, 3.x is specifically 3.12.3, which is the same as 3.12. So getting rid of 3.x wouldn't solve the problem, because the 3.12 test would fail for the same reason.

I looked into the failure, though, and I'm pretty sure it was caused by a too-old version of setuptools.
Python 3.12 requires setuptools>=66.1.0 (see pypa/setuptools#3685), but the version of setuptools used for CI was pinned to 65.6.3. Note that this is actually the same problem I tried to address in d6bbca6, but in that commit I only updated the setuptools version used to install pymanopt itself. I didn't notice that there was another pin specifically for CI. I just pushed a commit that updates this pin; hopefully that will work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for having looked at this!

steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["pip==22.3.1", "setuptools==65.6.3", "setuptools-scm[toml]>=6.2"]
requires = ["pip==22.3.1", "setuptools>=66.1.0", "setuptools-scm[toml]>=6.2"]
build-backend = "setuptools.build_meta"

[project]
Expand Down Expand Up @@ -37,7 +37,7 @@ classifiers = [
]
dependencies = [
"numpy>=1.16.0",
"scipy>=1.0,<1.10",
"scipy>=1.0,!=1.10.*,!=1.11.*,!=1.12.*",
]
[project.urls]
homepage = "https://pymanopt.org"
Expand Down
Loading