We don't need to store index at each node.

[howsiyu]

No description provided.

[aloctavodia]

LGTM! If there is not objection from @fjloyola I will merge.

[fjloyola]

LGTM! If there is not objection from @fjloyola I will merge.

It's ok for me, as it is simpler I feel that is a good change and will improve the memory uses ( taking away redundant data),

about this change,

@lru_cache
def get_depth(index: int) -> int:
    return math.floor(math.log2(index + 1))
    return (index + 1).bit_length() - 1

probably with this type of operation we don't need to cache the response because is not that expensive .bit_lenght() we should check performance later without the decorator

[aloctavodia]

LGTM! If there is not objection from @fjloyola I will merge.

It's ok for me, as it is simpler I feel that is a good change and will improve the memory uses ( taking away redundant data),

about this change,

@lru_cache
def get_depth(index: int) -> int:
    return math.floor(math.log2(index + 1))
    return (index + 1).bit_length() - 1

probably with this type of operation we don't need to cache the response because is not that expensive .bit_lenght() we should check performance later without the decorator

Thanks for checking! I think we can leave this as is for the moment. And then discuss removing the cache. Also, we can even compute precompute this only once, because we know the maximum depth (it is just a function of a hyper-paramenter).