Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sampler stats #46

Closed
OriolAbril opened this issue Mar 24, 2021 · 3 comments · Fixed by #338
Closed

sampler stats #46

OriolAbril opened this issue Mar 24, 2021 · 3 comments · Fixed by #338
Labels
high impact Notebooks with most visits on docs.pymc.io tracker id Issues used as trackers in the notebook update project, do not close!

Comments

@OriolAbril
Copy link
Member

file: https://github.com/pymc-devs/pymc-examples/blob/main/examples/diagnostics_and_criticism/sampler-stats.ipynb

Required changes

The notebook should use InferenceData and ArviZ for plotting. Note that the names of the sampler stats in ArviZ are different, the naming convention for ArviZ can be found at https://arviz-devs.github.io/arviz/schema/schema.html#sample-stats, doc which should be linked too.

Changes for discussion

I think it would be a good addition to add a plot_parallel as a quick way to visualize divergences or to link to the notebook on divergences.

@OriolAbril OriolAbril added this to General updates in Notebook state tracker Mar 24, 2021
@OriolAbril OriolAbril added good first issue Good for newcomers tracker id Issues used as trackers in the notebook update project, do not close! labels Mar 24, 2021
@mjhajharia
Copy link
Member

that sounds like a good idea, I feel like adding more math-y info of those stats would be helpful, because in this notebook I think there's just trace.stat_names, which is sort of just documentation all over again, probably example notebooks should be doing more, I think what I'm trying to say is they can be somewhat pedagogical, I don't know if i make a lot of sense. But I'll be happy to work on it

@canyon289
Copy link
Member

Assigned you @almostmeenal. Based on our early conversations regarding GSOC and your interests this seems like a great one to both help you work on the types of OSS youd like to, as well as to keep building up your experience for a strong application (for any project you apply to)!

@mjhajharia
Copy link
Member

mjhajharia commented Mar 25, 2021 via email

This was referenced Apr 2, 2021
@OriolAbril OriolAbril moved this from General updates to Best practices in Notebook state tracker Apr 6, 2021
@OriolAbril OriolAbril added high impact Notebooks with most visits on docs.pymc.io and removed good first issue Good for newcomers labels Apr 6, 2021
Notebook state tracker automation moved this from Best practices (v3) to Done May 31, 2022
twiecki pushed a commit that referenced this issue Jan 17, 2023
* add shape argument

* swicth dimensions

* clean samplers

* use size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high impact Notebooks with most visits on docs.pymc.io tracker id Issues used as trackers in the notebook update project, do not close!
Projects
Development

Successfully merging a pull request may close this issue.

3 participants