-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rerun script #264
Add rerun script #264
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
_log = logging.getLogger(__file__) | ||
DP_REPO = pathlib.Path(__file__).absolute().parent.parent | ||
|
||
REPLACEMENTS = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order matters here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so that's why there's the stundenat
→studentt
!
I though you were correcting typos there..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not make this an OrderedDict or can we rely on dict
being ordered now?
This is related to #52, so we keep track of everything. I will also create a The PR LGTM, and merging this and aiming for multiple PRs also allows anyone to help. |
#265 updates the BEST example on both code and style, can we autoupdate another notebook here to avoid merge issues? |
45a2826
to
f524694
Compare
f524694
to
3af8c6f
Compare
Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com>
98168e2
to
73ff0fd
Compare
What happened to the AB testing NB? |
I undid that commit to avoid conflicts, as requested by The notebook I re-ran now needed a manual intervention, but I got annoyed by automated re-runs not working, so I just fixed it. |
related to #110 |
"arviz.from_pymc3": "pm.to_inference_data", | ||
"pymc3": "pymc", | ||
"PyMC3": "PyMC", | ||
"pymc3": "pymc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these occur twice.
This PR adds
scripts/rerun.py
and applies it to the BEST notebook.It can be used from the command line or from another Python script to apply API migrations, re-run notebooks and optionally commit to a specific branch and push it to a remote.
The replacements are the ones @twiecki wrote for #262.
For example, this is how we can apply it for the example scripts:
@twiecki @OriolAbril I think we should chunk the work and, for example, have one PR that updates only the example scripts like shown above.
If needed those PRs can then adapt the
REPLACEMENTS
.