New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LKJ nb to avoid crashing at model seeding #583

Merged

OriolAbril merged 1 commit into pymc-devs:main from erik-werner:LKJ_v5

Oct 12, 2023

Contributor

erik-werner commented Oct 12, 2023 •

edited by github-actions bot

Loading

Issue #53

Update to do random seeding in the sample function instead of model building (see #5787)
Remove unnecessary import and env variable

Notebook follows style guide https://docs.pymc.io/en/latest/contributing/jupyter_style.html
PR description contains a link to the relevant issue:
- a tracker one for existing notebooks (tracker issues have the "tracker id" label)
- or a proposal one for new notebooks
Check the notebook is not excluded from any pre-commit check: https://github.com/pymc-devs/pymc-examples/blob/main/.pre-commit-config.yaml

📚 Documentation preview 📚: https://pymc-examples--583.org.readthedocs.build/en/583/


          Update LKJ nb from v4 to v5

36b3fda

review-notebook-app bot commented Oct 12, 2023

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

OriolAbril approved these changes

View reviewed changes

OriolAbril merged commit 613d1e3 into pymc-devs:main

3 checks passed

erik-werner deleted the LKJ_v5 branch

October 13, 2023 09:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment