Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PyTensor to 2.9.1 #6431

Merged
merged 3 commits into from Jan 12, 2023
Merged

Bump PyTensor to 2.9.1 #6431

merged 3 commits into from Jan 12, 2023

Conversation

michaelosthege
Copy link
Member

@michaelosthege michaelosthege commented Jan 4, 2023

What is this PR about?
Updating to the latest PyTensor version, because I'm looking forward to a bugfix in the release after, and I want things to go smooth =)

After major complications due to (unnoticed) broken release pipelines on the PyTensor side, it appears that the upgrade actually was comparably smooth with only a minor typing issue.

Checklist

Major / Breaking Changes

  • Updated PyTensor 2.8.11→2.9.1

Maintenance

  • Turned off *.tar.bz2-only installations because PyTensor 2.9.1 is no longer available from .tar-bz2 artifacts. This may break caching in GitHub Actions.

@michaelosthege michaelosthege added pytensor major Include in major changes release notes section labels Jan 4, 2023
@michaelosthege
Copy link
Member Author

image

@twiecki
Copy link
Member

twiecki commented Jan 4, 2023

Also requires pre-commit (and rtd?)

@michaelosthege
Copy link
Member Author

Also requires pre-commit (and rtd?)

I did a Ctrl+H for 2.8.11..
Also checked again, but pre-commit config and rtd don't specify PyTensor versions 🙂

@michaelosthege michaelosthege changed the title Bump PyTensor to 2.8.12 Bump PyTensor to 2.9.1 Jan 11, 2023
@twiecki
Copy link
Member

twiecki commented Jan 12, 2023

Updated PyTensor 2.8.11→2.8.12

@michaelosthege
Copy link
Member Author

We might be running into problems with our environment creation settings:
I can mamba create -n pttest -c conda-forge pytensor=="2.9.1" just fine locally, but in CI it says nothing provides requested pytensor 2.9.1** on all three OS.

The only difference w.r.t. 2.8.11 I can spot is that 2.8.11 was available as *.tar.bz2 artifacts on conda-forge but 2.9.1 is only available as *.conda artifacts.

IIRC there's something about the conda caching forcing us to install from *.tar.bz2 artifacts; currently looking for the respective lines in the yamls...

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #6431 (e062237) into main (3d747af) will decrease coverage by 55.71%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6431       +/-   ##
===========================================
- Coverage   94.77%   39.05%   -55.72%     
===========================================
  Files         148      148               
  Lines       27730    27717       -13     
===========================================
- Hits        26280    10825    -15455     
- Misses       1450    16892    +15442     
Impacted Files Coverage Δ
pymc/distributions/shape_utils.py 42.79% <0.00%> (-55.08%) ⬇️
pymc/tests/backends/test_base.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_utils.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_cumsum.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/tuning/test_scaling.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_mixture.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/tuning/test_starting.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/backends/test_ndarray.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_abstract.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/sampling/test_forward.py 0.00% <0.00%> (-100.00%) ⬇️
... and 102 more

@michaelosthege michaelosthege marked this pull request as ready for review January 12, 2023 16:18
@twiecki twiecki merged commit c3b8ff4 into pymc-devs:main Jan 12, 2023
@michaelosthege michaelosthege deleted the pytensor2812 branch January 12, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Include in major changes release notes section pytensor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants