-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DIC with multiple chains #648
Comments
It was intentional, but I'm happy to rethink it. I figured one chain would be enough to get a reasonable DIC estimate, and if it varied a lot from chain to chain, then you would not be happy with the set of non-converged samples anyhow, so you wouldnt need DIC. At present it is a property, but we could make it a function that took a model and a
Would that be a better implementation? |
Thanks. I agree that the current implementation is pretty reasonable given what you say. I don't have a sense of whether there would be any real difference in the computed value given that you're happy with convergence. I've seen sometimes in the literature preference given to one model over another based on pretty small (subjectively) differences in DIC, but that's a methodological issue. Maybe more important sub-question, what about also adding a |
The PyMC 2 is very much geared towards a burn-at-sampling workflow, given the |
I had that impression but surprisingly found that for the most part I could get by with post-sampling adjustments. I just rolled my own as a solution. Up to you whether you want to add the convenience function. Feel free to close this as you see fit. I only tried briefly to install pymc 3. Will probably switch to it after I wrap up this project and continue to do more statistics by simulation. |
Should this issue be moved to |
Splitting up the repos? 👍 |
Moving this over to #2 |
@jseabold What was your solution? |
The way the deviance information criteria code is written in 2.x right now, IIUC only the last chain is used because the default argument for
nchains
in the Trace objects is -1. Is this intentional? I guess in practice, it may not end up mattering much if you're reasonably happy with the sampling from the posterior in the last chain, but if I'm running multiple chains from overdispersed starting values wouldn't I want to compute the DIC from traces of all the chains?The text was updated successfully, but these errors were encountered: