Skip to content

Commit

Permalink
Add mkl-service to build (#1572)
Browse files Browse the repository at this point in the history
  • Loading branch information
@ColCarroll @twiecki
ColCarroll authored and twiecki committed Dec 3, 2016
1 parent 493d281 commit 2edbe6c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/create_testenv.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ then
source activate testenv
fi

conda install --yes pyqt=4.11.4 jupyter pyzmq numpy scipy nose matplotlib pandas Cython patsy statsmodels joblib coverage
conda install --yes pyqt=4.11.4 jupyter pyzmq numpy scipy nose matplotlib pandas Cython patsy statsmodels joblib coverage mkl-service
if [ ${PYTHON_VERSION} == "2.7" ]; then
conda install --yes mock enum34;
fi
Expand Down

3 comments on commit 2edbe6c

@usptact
Copy link
Contributor

@usptact usptact commented on 2edbe6c Dec 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ColCarroll Why is mkl-service needed in PyMC3? Is this Intel MKL library support or something else?

@ColCarroll
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly addressed the reasoning in the PR for this (#1572). It is Intel MKL optimizations. I'm not super familiar with the differences in optimization libraries, but theano was issuing a warning if it wasn't installed. If you have some expertise, would love to learn!

Note that this does not install mkl-service when pip installing or conda installing pymc3.

@usptact
Copy link
Contributor

@usptact usptact commented on 2edbe6c Dec 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ColCarroll Thanks for the details! I checked my win-64 anaconda install and noticed that "mkl-service" package has been already installed as a dependency to some of my packages of interest. PyMC3 is installed in the same environment; it must be other python package then which pulled it as a dependency.

Please sign in to comment.