Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL Update version to 3.0. #1647

Merged
merged 5 commits into from
Jan 9, 2017
Merged

REL Update version to 3.0. #1647

merged 5 commits into from
Jan 9, 2017

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented Jan 6, 2017

No description provided.

@springcoil
Copy link
Contributor

This LGTM - but the BDFL gets final say.

@springcoil
Copy link
Contributor

@ColCarroll Add in the readme...

@ColCarroll
Copy link
Member

Er, will need to make sure tests actually pass on 3.6 -- I can push something in ~2hrs after work unless someone else gets to it first. Hopefully it won't come up, but should tests passing on 3.6 be a release blocker?

@springcoil
Copy link
Contributor

Ohh that's a valid point. I wouldn't consider it being a release blocker. But @fonnesbeck is probably the one to ask.

@fonnesbeck
Copy link
Member

I don't think a 3.6 test is necessary for 3.0, but if someone feel strongly about it and wants to make it work, then I'm happy to wait a day.

@ColCarroll
Copy link
Member

Fails, but because of pyqt. I don't know much about the library -- grepping for it turns up no results, but maybe it is used for some of the plotting?

https://travis-ci.org/ColCarroll/pymc3/jobs/189623258

@springcoil
Copy link
Contributor

This looks good to me @twiecki in terms of documentation. Is the python 3.6 error fixed yet? cc @ColCarroll

@twiecki
Copy link
Member Author

twiecki commented Jan 9, 2017

I removed the 3.6 support.

@fonnesbeck fonnesbeck merged commit 40ccb10 into master Jan 9, 2017
@twiecki
Copy link
Member Author

twiecki commented Jan 9, 2017

Woohoo! Let's get conda-forge updated. Can you handle that @springcoil ?

@twiecki twiecki deleted the v3.0_release branch January 9, 2017 14:13
@fonnesbeck
Copy link
Member

Pushed to PyPI.

@springcoil
Copy link
Contributor

conda-forge/pymc3-feedstock#6 done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants