Upper lower #3424
Closed
Upper lower #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@junpenglao All check has passed. Please review it. |
lucianopaz
requested changes
Mar 24, 2019
There was a problem hiding this comment.
The commit history is a bit weird and shows all the commits you had done in your previous PR.
Nevertheless, you need to do 3 more things to get this done:
- Add a line to the 3.7 release notes under maintenance specifying this fix.
- Add tests to the test suite to explicitly test and ensure that the issue, Error for default params of NoneType in pm.distributions.distribution._draw_value() #3248, is fixed and all potential values for the bounds work well.
- Be careful about the
_normalizationfunction that relies on the bounds beingNoneor not. You should change this to someisinfkind of control.
There was a previous PR, #3250, that did this but became stale and was never finished. You can look at it to get some ideas.
| @@ -571,8 +571,8 @@ def __init__(self, mu=0, sigma=None, tau=None, lower=None, upper=None, | |||
| tau, sigma = get_tau_sigma(tau=tau, sigma=sigma) | |||
| self.sigma = self.sd = tt.as_tensor_variable(sigma) | |||
| self.tau = tt.as_tensor_variable(tau) | |||
| self.lower = tt.as_tensor_variable(floatX(lower)) if lower is not None else lower | |||
| self.upper = tt.as_tensor_variable(floatX(upper)) if upper is not None else upper | |||
| self.lower = tt.as_tensor_variable(floatX(lower)) if lower is not None else tt.as_tensor_variable(-np.inf) | |||
There was a problem hiding this comment.
You have to also floatX np.inf
There was a problem hiding this comment.
Thanks for your reply. I will check the pr 3250.
|
@chang111 Did you mean to close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the issue 3248