Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use codecov for code coverage #162

Merged
merged 5 commits into from Nov 21, 2019
Merged

Conversation

lucianopaz
Copy link
Contributor

Codecov was a nice replacement for coveralls in pymc3. This PR changes the currently used azure-pipelines coverage publisher and reporter tasks to codecov.io instead. We'll get the same nice coverage graphs for PRs and reports as in pymc3.

I also added a python3.8 test environment (as it's basically free because we haven't hit the limit of parallel jobs in azure).

@lucianopaz
Copy link
Contributor Author

Tensorflow and TFP don't seem to support python3.8 yet... I'll just drop the python3.8 test env entirely until they package TF and TFP for py38

@lucianopaz lucianopaz changed the title Use codecov for code coverage and add python3.8 Use codecov for code coverage Nov 21, 2019
@@ -44,14 +44,7 @@ steps:
python -m pytest -xv --cov pymc4 --junitxml=junit/test-results.xml --cov-report xml --cov-report term --cov-report html .
displayName: "pytest"

- task: PublishTestResults@2
- script: |
bash <(curl -s https://codecov.io/bash)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat! does this just run a bash script that will check for $CODECOV_TOKEN?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. At least it doesn't seem to be required on azure

@lucianopaz
Copy link
Contributor Author

I made an almost empty commit to get the first coverage report uploaded properly to codecov

@lucianopaz lucianopaz merged commit 2a60c32 into pymc-devs:master Nov 21, 2019
@lucianopaz lucianopaz deleted the codecov branch November 25, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants