Deprecate extract_diag and linalg.trace in favor of numpy look-alikes
#428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
numpy_trace
branch
from
b97326a
to
2699de8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
- Coverage 80.77% 80.76% -0.01%
==========================================
Files 159 159
Lines 45847 45853 +6
Branches 11233 11233
==========================================
+ Hits 37032 37034 +2
- Misses 6588 6591 +3
- Partials 2227 2228 +1
|
ricardoV94
force-pushed
the
numpy_trace
branch
from
2699de8
to
fe70176
Compare
twiecki
reviewed
Sep 6, 2023
ricardoV94
force-pushed
the
numpy_trace
branch
from
fe70176
to
bfbe0ac
Compare
ricardoV94
force-pushed
the
numpy_trace
branch
from
206e406
to
76a1354
Compare
twiecki
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide the same function names and behavior as numpy to reduce confusion