Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #672

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Mar 18, 2024

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.3.2 → v0.3.3](astral-sh/ruff-pre-commit@v0.3.2...v0.3.3)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 9ca2085 to 6e74d16 Compare March 18, 2024 17:34
@ricardoV94
Copy link
Member

@michaelosthege do you know how to tell mypy to ignore the unused ignore :) It's needed in 3.9, but not in 3.12

@maresb
Copy link
Contributor

maresb commented Mar 20, 2024

@ricardoV94 I think you need to set this

@ricardoV94
Copy link
Member

@ricardoV94 I think you need to set this

Wanna try?

@Armavica
Copy link
Member

@ricardoV94 I think you need to set this

It was a mypy error so I set this parameter to "3.9". One more thing to update when we upgrade python, unfortunately…

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (e427954) to head (cd79f66).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #672   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files         162      162           
  Lines       46830    46830           
  Branches    11446    11446           
=======================================
  Hits        37857    37857           
  Misses       6710     6710           
  Partials     2263     2263           

see 2 files with indirect coverage changes

@ricardoV94 ricardoV94 merged commit 339aab4 into main Mar 20, 2024
53 checks passed
@ricardoV94
Copy link
Member

Thanks a lot @Armavica

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants