Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make local_pow_to_nested_squaring rewrite more permissive #742

Merged
merged 1 commit into from
May 2, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented May 2, 2024

Description

Showed up in #740 and it was a result of a conservative fix to #456 in #461

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94 ricardoV94 changed the title Make local_pow_to_nested_squaring more permissive Make local_pow_to_nested_squaring more permissive May 2, 2024
twiecki
twiecki previously approved these changes May 2, 2024
@twiecki
Copy link
Member

twiecki commented May 2, 2024

Oops, I clicked on approve by accident, I didn't actually review :)

@ricardoV94 ricardoV94 dismissed twiecki’s stale review May 2, 2024 14:29

He didn't mean it

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@27bd9aa). Click here to learn what that means.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #742   +/-   ##
=======================================
  Coverage        ?   80.81%           
=======================================
  Files           ?      162           
  Lines           ?    46808           
  Branches        ?    11452           
=======================================
  Hits            ?    37826           
  Misses          ?     6734           
  Partials        ?     2248           
Files Coverage Δ
pytensor/tensor/rewriting/math.py 87.13% <ø> (ø)

@ricardoV94 ricardoV94 requested a review from aseyboldt May 2, 2024 16:23
@ricardoV94
Copy link
Member Author

ricardoV94 commented May 2, 2024

All tests pass. The check was too conservative on my part. It should be fine. The only edge case I can think of is when the exponent broadcasts the base, but that is checked before the and we get out if that's the case

Copy link
Member

@aseyboldt aseyboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

@ricardoV94 ricardoV94 merged commit b8e26cd into pymc-devs:main May 2, 2024
55 checks passed
@ricardoV94 ricardoV94 changed the title Make local_pow_to_nested_squaring more permissive Make local_pow_to_nested_squaring rewrite more permissive May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants