Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example NB plots are compressed #666

Open
twiecki opened this issue May 2, 2024 · 7 comments · Fixed by #667
Open

Example NB plots are compressed #666

twiecki opened this issue May 2, 2024 · 7 comments · Fixed by #667
Labels
docs Improvements or additions to documentation

Comments

@twiecki
Copy link
Contributor

twiecki commented May 2, 2024

image

https://www.pymc-marketing.io/en/stable/notebooks/mmm/mmm_lift_test.html

@wd60622
Copy link
Contributor

wd60622 commented May 2, 2024

noticed that too ☹️

@ColtAllen
Copy link
Collaborator

This is also impacting the CLV notebooks. I tried changing the fig size in the plotting code, but it made no difference. I'm thinking we need to specify something in conf.py related to pydata-sphinx-theme.

@twiecki
Copy link
Contributor Author

twiecki commented May 2, 2024

Maybe @OriolAbril has an idea.

@juanitorduz
Copy link
Collaborator

can it be related to executablebooks/MyST-NB#588?

@juanitorduz
Copy link
Collaborator

juanitorduz commented May 3, 2024

mmmm when I build the docs locally make html it works with myst_nb == 1.0 so, when the PR above has not merged ...

@juanitorduz
Copy link
Collaborator

Here is a quick fix #667 . We might need a better solution. I think one has to tweak the nb_cell_metadata_key, but I did not manage to do it :(

@juanitorduz
Copy link
Collaborator

I will re-open this issue as the fix in #667 should not be final as we do not want to restrict the versions :)

@juanitorduz juanitorduz added the docs Improvements or additions to documentation label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants