Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Try] Fix compressed images in docs. #667

Merged
merged 3 commits into from
May 3, 2024
Merged

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented May 3, 2024

Trying to fix #666


📚 Documentation preview 📚: https://pymc-marketing--667.org.readthedocs.build/en/667/

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (19bbf6d) to head (3888ac1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          24       24           
  Lines        2380     2380           
=======================================
  Hits         2190     2190           
  Misses        190      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz
Copy link
Collaborator Author

ok It seems restricting the myst_nb version fixes the problem. @OriolAbril is there a better way?

I suggest we merge this one and then come back with a better fix. WDYT?

@juanitorduz juanitorduz requested a review from wd60622 May 3, 2024 08:18
@juanitorduz juanitorduz added bug Something isn't working docs Improvements or additions to documentation help wanted Extra attention is needed priority: high labels May 3, 2024
@twiecki
Copy link
Contributor

twiecki commented May 3, 2024

That does fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation help wanted Extra attention is needed priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example NB plots are compressed
2 participants