New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vectorize adstock transformations #15
Conversation
In 9257d0b I added an experimental implementation of the geometric adstock function using |
Well ... I really tried my best to write a geometric adstock function which was able to handle scalar and vector values, could accept the In my current project I have used the Hence, we could simply remove I am sorry about the d-tour with the |
In 462b69d I removed the implementation using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just left two small comments regarding the tests
In this PR we add a vectorized version of the adstoc transformations to avoid writing for loops when going over channels transformations. For example, for 3 channels and 169 observation we can write: