Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many instruments miss name argument #658

Closed
BenediktBurger opened this issue Aug 2, 2022 · 1 comment · Fixed by #659 or #877
Closed

Many instruments miss name argument #658

BenediktBurger opened this issue Aug 2, 2022 · 1 comment · Fixed by #659 or #877
Labels
enhancement

Comments

@BenediktBurger
Copy link
Member

Many instruments miss a name argument and pass their name directly to the super constructor.
@BenediktBurger BenediktBurger mentioned this issue Aug 2, 2022
Merged
2 tasks
BenediktBurger added a commit to BenediktBurger/pymeasure that referenced this issue Aug 3, 2022
@BenediktBurger
Instruments from 't' to 'z'. Closes pymeasure#658.
6f12dde
BenediktBurger added a commit to BenediktBurger/pymeasure that referenced this issue Aug 6, 2022
@BenediktBurger
Instruments from 't' to 'z'. Closes pymeasure#658.
a00eed7
BenediktBurger added a commit to BenediktBurger/pymeasure that referenced this issue Nov 15, 2022
@BenediktBurger
Instruments from 't' to 'z'. Closes pymeasure#658.
f22c6ae 
# Conflicts:
#	pymeasure/instruments/newport/esp300.py
#	pymeasure/instruments/parker/parkerGV6.py
#	pymeasure/instruments/pendulum/cnt91.py
#	pymeasure/instruments/rohdeschwarz/fsl.py
#	pymeasure/instruments/rohdeschwarz/sfm.py
#	pymeasure/instruments/signalrecovery/dsp7265.py
#	pymeasure/instruments/srs/sg380.py
#	pymeasure/instruments/srs/sr510.py
#	pymeasure/instruments/srs/sr570.py
#	pymeasure/instruments/srs/sr830.py
#	pymeasure/instruments/srs/sr860.py
#	pymeasure/instruments/tektronix/tds2000.py
#	pymeasure/instruments/thermotron/thermotron3800.py
#	pymeasure/instruments/thorlabs/thorlabspro8000.py
#	pymeasure/instruments/toptica/ibeamsmart.py
@BenediktBurger
Copy link
Member Author

#659 added the docs and tests, but many current instruments (see list in test_all_instruments) do not confirm yet.

This work could be united with the change to a Scpi mixin.

Also a few instruments (among those Keysight N7776, LakeShore421) use super(Parent, self) .

@BenediktBurger BenediktBurger mentioned this issue Dec 23, 2022
Closed
@BenediktBurger BenediktBurger mentioned this issue Jan 16, 2023
Open
@BenediktBurger BenediktBurger mentioned this issue Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@bilderbuchi @BenediktBurger