Driver for the HP 8116A 50 MHz Pulse/Function Generator #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmttchr
reviewed
Jan 2, 2022
LongnoseRob
reviewed
Jan 3, 2022
There was a problem hiding this comment.
@CodingMarco that looks very promising!
One thing I did not see is the check_errors function, to see if the instrument reoirts any errors (if such a status or command is available on the instrument)
Another item, that you could still add is the hp8116A.rst in docs/api/instruments/hp/
For that you could copy the hp3478A.rst and change it to match for the 8116, also than please add the hp8116A.rst to the index.rst
msmttchr
reviewed
Jan 8, 2022
CodingMarco
changed the title
msmttchr
requested changes
Jan 12, 2022
msmttchr
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a driver for the HP 8116A. I have tested it as good as possible with two units, one with and one without option 001 (sweep/burst capability).