Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MKS937B check_set_errors functions and improve tests #936

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

dkriegner
Copy link
Contributor

previously the test did not cover any property setter. Also the check_set_errors function did not read back the additional termination characters. check_set_errors now returns a list upon success as required.

This fixes #935

previously the test did not cover any property setter. Also the
check_set_errors function did not read back the additional termination
characters. check_set_errors now returns a list upon success as
required.
@BenediktBurger
Copy link
Member

Thanks for the fix. It looks good.
Did you test the change with a device, that the additional read does not break the device?

@dkriegner
Copy link
Contributor Author

I checked it with the hardware and the extra terminators are sent by the device as mimicked by the test code. It previously went unnoticed since the extra terminator characters were ignored by the regular expression parsing the reply.

@BenediktBurger BenediktBurger changed the title fix check_set_errors functions and improve tests fix MKS937B check_set_errors functions and improve tests Jun 28, 2023
@BenediktBurger
Copy link
Member

Thanks for checking.

@BenediktBurger BenediktBurger merged commit de55c6e into pymeasure:master Jun 28, 2023
13 checks passed
@dkriegner dkriegner deleted the fix_mks937b branch June 28, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

recent changes break MKS937B check_set_errors
2 participants