Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default global_normalisation from the maximum value of dose_reference to dose_evaluation #1604

Closed
wants to merge 7 commits into from
Closed

Change the default global_normalisation from the maximum value of dose_reference to dose_evaluation #1604

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5b99b9
Add files via upload
guanfada Dec 26, 2021
e423a4e
merge main
SimonBiggs Mar 30, 2022
bdf77b1
commit changes to poetry.lock and setup.py
pymedphys-bot Mar 30, 2022
c27bb6c
Fix propagate failures
pymedphys-bot Mar 30, 2022
7ecd747
Merge remote-tracking branch 'origin/main' into guanfada-patch-1
SimonBiggs Mar 30, 2022
c74b732
Merge branch 'main' into guanfada-patch-1
SimonBiggs Jun 10, 2022
670888b
Merge branch 'main' into guanfada-patch-1
SimonBiggs Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/pymedphys/_gamma/implementation/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def gamma_shell(
False.
global_normalisation : float, optional
The dose normalisation value that the percent inputs calculate from.
Defaults to the maximum value of :obj:`dose_reference`.
Defaults to the maximum value of :obj:`dose_evaluation`.
random_subset : int, optional
Used to only calculate a random subset of the reference grid. The
number chosen is how many random points to calculate.
Expand Down Expand Up @@ -250,7 +250,7 @@ def from_user_inputs(
distance_mm_threshold = expand_dims_to_1d(distance_mm_threshold)

if global_normalisation is None:
global_normalisation = np.max(dose_reference)
global_normalisation = np.max(dose_evaluation)

lower_dose_cutoff = lower_percent_dose_cutoff / 100 * global_normalisation

Expand Down