Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forced snatch of a multi ep doesnt mark as snatch #229

Closed
duramato opened this issue Mar 28, 2016 · 6 comments
Closed

Forced snatch of a multi ep doesnt mark as snatch #229

duramato opened this issue Mar 28, 2016 · 6 comments
Labels
Bug
Milestone
0.2.9

Comments

@duramato
Copy link
Contributor

Branch/Commit: 134830f
OS: Ubuntu 14
What you did: For the snatch from manual snacth to mark all ep as snatched
What happened: When manually snatching X-Files.S01E01-17.DVDRip.XviD-SDG only the ep the manual snatch page was got marked as snatched
What you expected: All of the ep to be marked as snatched as on a manual search
@fernandog fernandog mentioned this issue Mar 31, 2016
Merged
@fernandog fernandog added the Bug label Apr 5, 2016
@duramato
Copy link
Contributor Author

duramato commented Sep 3, 2017

This is happening again:

For: The.Path.S02e07-13.mux.h264.ita.Ac3.webmux.-.ade

Only the episode 11 got marked as snatched:

image

For: The.Path.S02e07-13.mux.h264.ita.Ac3.webmux.-.ade
GuessIt found: {
    "title": "The Path",
    "season": 2,
    "episode": [
        7,
        8,
        9,
        10,
        11,
        12,
        13
    ],
    "episode_title": "mux",
    "video_codec": "h264",
    "language": "Italian",
    "audio_codec": "AC3",
    "format": "WEB-DL",
    "other": "Mux",
    "release_group": "ade",
    "type": "episode"
}

@fernandog

@duramato duramato reopened this Sep 3, 2017
@medariox
Copy link
Contributor

Just tested this and it is working as expected now.

@duramato
Copy link
Contributor Author

duramato commented Jul 11, 2018 •
edited

Just tested again on a clean develop install and it still doesn't. For: 12.Monkeys.S04E10-E11.720p.HDTV.x264-KILLERS

Log: https://gist.github.com/duramato/7a3bf8aedc65eb44a6b9b1fc76490b70

Only E11 get's marked as snatched.

image

@duramato duramato reopened this Jul 11, 2018
@medariox
Copy link
Contributor

That's not a manual snatch?

@duramato
Copy link
Contributor Author

Yes it seems the issue is now only present on a forced search

@medariox medariox changed the title Manual snatch of a multi ep doesnt mark as snatch Forced snatch of a multi ep doesnt mark as snatch Jul 11, 2018
@OmgImAlexis OmgImAlexis added this to the 0.2.8 milestone Jul 13, 2018
medariox added a commit that referenced this issue Jul 15, 2018
@medariox
Improve multi-episode and season snatches. Fixes #229
fe095c5
@medariox medariox mentioned this issue Jul 15, 2018
Merged
3 tasks
p0psicles pushed a commit that referenced this issue Aug 1, 2018
@medariox @p0psicles
Improve multi-episode and season snatches. Fixes #229. Fixes #4750 (#…
55bfdaf 
…4675)

* Rename Season search mode to Backlog search mode

* Improve multi-episode and season snatches. Fixes #229

* Remove unused import

* Add support for multi-episodes cache results, remove naive quality comparisions

* Add TODO

* Better formatting

* Remove support to download seasons for multi-episodes (torrents only)

* Use plural for better representation

* Review

* Update CHANGELOG.md

* Moved v0.2.9 changelog items to 'Unreleased'
@sharkykh
Copy link
Contributor

Fixed in develop with #4675.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.2.9
Development

No branches or pull requests
5 participants
@fernandog @medariox @OmgImAlexis @duramato @sharkykh