Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize the imdb_id #10923

Merged
merged 2 commits into from Sep 10, 2022
Merged

Normalize the imdb_id #10923

merged 2 commits into from Sep 10, 2022

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Sep 9, 2022 •
edited

  • make sure we store imdb_id without tt in indexer_mapping
  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@p0psicles
Normalize the imdb_id
d6b42c4 
* make sure we store imdb_id without `tt` in indexer_mapping
@p0psicles p0psicles added this to the 1.0.9 milestone Sep 9, 2022
@p0psicles p0psicles linked an issue Sep 9, 2022 that may be closed by this pull request
BUG OR DESIGN #10922
Closed
@p0psicles p0psicles merged commit ca129da into develop Sep 10, 2022
@p0psicles p0psicles deleted the feature/fix-recommended-show-in-lib branch September 10, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Concluded
Projects
None yet
Milestone
1.0.9
Development

Successfully merging this pull request may close these issues.

BUG OR DESIGN
1 participant
@p0psicles