Add RSS Feed Client #11123
Add RSS Feed Client #11123
Conversation
|
Thanks for the PR, it looks great! Medusa/tests/apiv2/test_config.py Line 506 in 31bbc70 section_data['rss'] = {} needs to be added to the test.
|
Done. You probably saw that I did manage to get the frontend built around my changed (I know almost nothing about npm or any of that workflow) and the massive amount of changes that produced. Is that going to be a problem? I can revert that commit if that would make merging easier. |
|
@sawyersteven |
|
Your test seems to be failing with Python 3.7, see: https://github.com/pymedusa/Medusa/actions/runs/4217939243/jobs/7352586386#step:5:93 |
The previous test compared the xml as a string to an expected string. This worked occasionally because the xml writer will sometimes place attributes in a random order. Also a bunch of formatting changes while I tried to eliminate warnings
…into develop-rss
|
Seems to be a problem with ElementTree putting xml attributes in a random order, which (of course) worked fine for me when I tested it. I just pushed a better test and the frontend build with the command posted above. |
|
Well that's irritating. A classic case of it works on my machine I'll have to try and abuse it some and see what the problem is. |
Change import from ET to ElemTree and change whitespace location in expected string to satisfy Flake8. This doesn't affect the test, but unclogs the test output a little. Recursive test fails on assertion rather than returning bool to bubble up through the nested generators. Strip newlines from expected string before parsing in ElementTree
|
Will be available with the upcoming release. Thank you! |
|
Awesome, thank you! |
Adds a RSS feed client for both nzb and torrents.
Why?
In broad strokes, its similar to a blackhole client in that Medusa will simply grab the result and promptly forget about it, requiring the client to alert Medusa when the download is complete and ready for processing.
The main benefit is that this allows for a download client on a different network to simply read the rss file (which can be exposed easily through any reverse proxy) instead of needing to mount the blackhole directory to download and/or delete torrent and nzb files.
It also allows an effortless one-to-many relationship between Medusa and a download client in case you want to send the feed to several different locations to download simultaneously. I can't think of a particular use case for that, but I'm sure it can help someone.
The frontend changes will need to be built before merging with master. My frontend skills are not great, though I did get this to build and run. Still, it seemed wise to me to let someone familiar with npm and yarn and everything else to do it properly.