Convert editShow to Vue store and SFC #4486

OmgImAlexis · 2018-06-28T10:15:05Z

TODO

Fix anidb UI
~~double check some weird bug in massUpdate when checking multiple shows and running update~~ Can't reproduce it anymore ??

themes/dark/templates/editShow.mako

sharkykh

Just skimmed through...

themes-default/slim/views/editShow.mako

…eify-editShow # Conflicts: # themes-default/slim/src/store/modules/shows.js # themes-default/slim/views/editShow.mako # themes/dark/assets/js/vendors.js # themes/dark/templates/editShow.mako # themes/light/assets/js/vendors.js # themes/light/templates/editShow.mako

* Fixed bug in concattenating globalRequired words. * Removed mako vars from server/web/home/handler.py * Updated router.js for edit-show.vue component. * linting

p0psicles · 2019-06-11T19:17:22Z

I'm hijacking this PR.

p0psicles · 2019-06-11T19:19:29Z

themes-default/slim/src/components/edit-show.vue

+            }
+
+            const { indexer, id, $store } = this;
+            $store.dispatch('setShow', { indexer, id, data, save: true }).then(() => {


@sharkykh I'm not totally sure. Should we call an action in vuex, and have that 1. update store then 2. update the show using apiv2? Or update the show from here, like it's now?

@p0psicles
TL;DR: The action should call the patch and fetch the show again.

I didn't look at the rest of the code, but since some of the patch data can be ignored by the API handler (invalid values and such), and whatever you send does not necessarily become the new show config, I'd say we can't update the store using the same data that we're sending, and we must fetch the show after the patch is complete.
I don't see a way around this at the moment.

p0psicles · 2019-06-11T19:20:08Z

themes-default/slim/src/components/edit-show.vue

+            return this.$store.state.search.filters.ignored.map(x => x.toLowerCase());
+        },
+        globalRequired() {
+            return this.$store.state.search.filters.required.map(x => x.toLowerCase());


This was previously this.$store.state.search.filters.ignored.map(x => x.toLowerCase());

medusa/server/web/home/handler.py

editShow is vueified and does not have the logic anymore to handle posts.

Fixed

p0psicles · 2019-06-28T18:05:47Z

@sharkykh can you do a yarn dev for me? I still have my build env messed up

sharkykh · 2019-06-28T19:16:08Z

Do you think we should merge it now?
Hopefully we didn't miss anything major...

Edit:
There's one thing I think we should be doing still -

Medusa/themes-default/slim/src/components/show.vue

Lines 73 to 76 in 317bcb3

    
                   $store.commit('currentShow', { 
        
                       indexer, 
        
                       id 
        
                   });

The "show sub menu" makes use of the currentShow state.
~~I'll see if changing the code to use this is easy.~~ Done.

p0psicles · 2019-06-29T16:31:27Z

yeah lets merge

found small bug

OmgImAlexis added Enhancement In progress Do not merge labels Jun 28, 2018

sharkykh reviewed Jun 28, 2018

View reviewed changes

themes/dark/templates/editShow.mako Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

sharkykh reviewed Jun 28, 2018

View reviewed changes

themes-default/slim/views/editShow.mako Outdated Show resolved Hide resolved

themes-default/slim/views/editShow.mako Outdated Show resolved Hide resolved

themes-default/slim/views/editShow.mako Outdated Show resolved Hide resolved

p0psicles added the Squash / Rebase label Aug 10, 2018

OmgImAlexis added this to the backlog milestone Aug 10, 2018

p0psicles assigned OmgImAlexis Aug 21, 2018

p0psicles modified the milestones: backlog, 0.2.9 Aug 21, 2018

sharkykh added the Changelog Requires a changelog entry label Aug 23, 2018

convert editShow to vue store

0d1432c

sharkykh modified the milestones: 0.2.9, 0.2.10 Aug 28, 2018

Build themes

d8620ff

sharkykh force-pushed the feature/vueify-editShow branch from 38d911e to d8620ff Compare August 28, 2018 19:12

This comment has been minimized.

Sign in to view

sharkykh removed the Squash / Rebase label Aug 28, 2018

OmgImAlexis modified the milestones: 0.2.11, 0.2.12 Oct 29, 2018

p0psicles mentioned this pull request Jan 9, 2019

Remove MEDUSA.config and startVue #4765

Open

38 tasks

p0psicles added 3 commits June 11, 2019 19:53

Move editShow.mako -> components/edit-show.vue

e14a581

* Fixed bug in concattenating globalRequired words. * Removed mako vars from server/web/home/handler.py * Updated router.js for edit-show.vue component. * linting

Fixed indents (caused by rebase)

47e1c58

p0psicles reviewed Jun 11, 2019

View reviewed changes

sharkykh reviewed Jun 11, 2019

View reviewed changes

medusa/server/web/home/handler.py Outdated Show resolved Hide resolved

Added new route massEditShow as a replacement for editShow.

6c27c4a

editShow is vueified and does not have the logic anymore to handle posts.

sharkykh and others added 6 commits June 27, 2019 21:19

Get only the current show

94d90ad

Fix QualityChooser and EditShow race condition

a3065f7

Add missing theme to StateSwitch (AniDB component)

69c4abd

Remove async

9ac404a

Handle load errors

006db80

Fixed the "fetching release groups" spinner / message.

617b000

import order & simplify mapState & [bundle]

62bd58f

sharkykh and others added 4 commits June 28, 2019 23:32

Use currentShow

c534660

Fix small lint issues

c24a5b4

Merge branch 'develop' into feature/vueify-editShow

1dd1c71

Object destructuring and tick strings.

0552300

p0psicles previously approved these changes Jun 29, 2019

View reviewed changes

sharkykh added Concluded and removed In progress labels Jun 29, 2019

rebundle

1769dc3

p0psicles dismissed their stale review via 1769dc3 June 29, 2019 16:35

sharkykh previously approved these changes Jun 29, 2019

View reviewed changes

Fix tiny mistake

9cbad98

sharkykh previously approved these changes Jun 29, 2019

View reviewed changes

Fix backlogOverview Edit Show link

1f3849b

sharkykh dismissed their stale review via 1f3849b June 29, 2019 17:30

sharkykh approved these changes Jun 29, 2019

View reviewed changes

p0psicles approved these changes Jun 29, 2019

View reviewed changes

p0psicles merged commit 16558b0 into develop Jun 29, 2019

p0psicles deleted the feature/vueify-editShow branch June 29, 2019 17:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert editShow to Vue store and SFC #4486

Convert editShow to Vue store and SFC #4486

OmgImAlexis commented Jun 28, 2018 •

edited by p0psicles

This comment has been minimized.

sharkykh left a comment

This comment has been minimized.

p0psicles commented Jun 11, 2019

p0psicles Jun 11, 2019

sharkykh Jun 11, 2019 •

edited

p0psicles Jun 11, 2019

p0psicles commented Jun 28, 2019

sharkykh commented Jun 28, 2019 •

edited

p0psicles commented Jun 29, 2019

Convert editShow to Vue store and SFC #4486

Convert editShow to Vue store and SFC #4486

Conversation

OmgImAlexis commented Jun 28, 2018 • edited by p0psicles

TODO

This comment has been minimized.

sharkykh left a comment

Choose a reason for hiding this comment

This comment has been minimized.

p0psicles commented Jun 11, 2019

p0psicles Jun 11, 2019

Choose a reason for hiding this comment

sharkykh Jun 11, 2019 • edited

Choose a reason for hiding this comment

p0psicles Jun 11, 2019

Choose a reason for hiding this comment

p0psicles commented Jun 28, 2019

sharkykh commented Jun 28, 2019 • edited

p0psicles commented Jun 29, 2019

OmgImAlexis commented Jun 28, 2018 •

edited by p0psicles

sharkykh Jun 11, 2019 •

edited

sharkykh commented Jun 28, 2019 •

edited