Bundle using Webpack #4692
Merged
Bundle using Webpack #4692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't register components twice.
|
In the meantime we can use: cd themes-default/slim
yarn webpack && yarn gulp sync |
- api.js - router.js - store.js - axios - http-vue-loader - vue - vue-async-computed - vue-in-viewport-mixin - vue-js-toggle-button - vue-meta - vue-native-websocket - vue-router - vuex
|
@sharkykh can we try and get this merged today? |
OmgImAlexis
commented
Jul 28, 2018
| @@ -4,10 +4,10 @@ | |||
| "name": "slim", | |||
| "author": "p0psicles", | |||
| "scripts": { | |||
| "gulp": "gulp", | |||
There was a problem hiding this comment.
We don't need this as yarn gulp is the same even if you don't have this.
sharkykh
force-pushed
the
feature/webpack
branch
from
d64e25d
to
60aefb6
Compare
sharkykh
force-pushed
the
feature/webpack
branch
from
60aefb6
to
2344421
Compare
sharkykh
approved these changes
Aug 1, 2018
|
Please don't forget to update the WIKI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this is a crappy single commit with loads of changes but I just wanted feedback before I continue.
This should work out of the box in the dark theme. Do not run any gulp commands, etc. or it'll break as I've had to manually change a few things after the sync.