Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add-show-options toggle buttons. #5709

Merged
merged 2 commits into from
Nov 14, 2018
Merged

Fix add-show-options toggle buttons. #5709

merged 2 commits into from
Nov 14, 2018

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Nov 13, 2018 •
edited
Loading

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

This fixes a bug that got introduced by #4913

@ghost
Copy link

ghost commented Nov 13, 2018

DeepCode analyzed this pull request.
There are no new issues.

@p0psicles p0psicles added this to the 0.2.12 milestone Nov 13, 2018
@OmgImAlexis
Copy link
Collaborator

This is going to end up mutating defaultConfig since you're using v-model. You probably only need value and the @input handler.

@p0psicles p0psicles merged commit 0e60fbc into develop Nov 14, 2018
@p0psicles p0psicles deleted the feature/fix-config-toggle-slider branch November 14, 2018 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmgImAlexis OmgImAlexis OmgImAlexis approved these changes

Assignees
No one assigned
Labels
Bug Concluded
Projects
None yet
Milestone
0.2.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@p0psicles @OmgImAlexis