Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Recommended shows version 2 #5782

Merged
merged 86 commits into from Aug 7, 2021
Merged

[WIP] Recommended shows version 2 #5782

merged 86 commits into from Aug 7, 2021

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Nov 25, 2018 •
edited

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

This is a complete rework of the recommended show page.
Goal of this PR is:

  • Cache recommended shows during a nightly scheduled task, in it's dedicated thread
  • Store all recommended show info in db (dogpile is still enabled) but will be removed eventually
  • Add text filter option
  • Add new recommended show pages. For example IMDB watchlists, personal anidb lists
  • Bring back the trakt and (other) subcategories
  • Have one Vue template that displays all posters, with more configuration options (in progress)
  • configure which recomm list you want to cache at night, or disable it
  • If disabled, the user can start the "nightly" scheduled task, manually and wait for results.
  • Instead of just adding, you will now get a dropdown with the indexers to directly add them to. It uses the internal indexer_mapping table. So for example trakt provides the shows with a tvdb and tmdb id. You can then choose which indexer you want to use.

image

@p0psicles
* Cache recommended shows in ShowUpdater
06eb0fd 
* Add link to trakt show (needs the anom from vue)
* Add option to disable rec show caching. (default on)
@p0psicles
Added recommended shows to store.
4b42002 
Moved addShows jquery, to vue mounted.
First start with working vue recommended show page.
@p0psicles
Added templates.
dfd5058
@ghost
Copy link

ghost commented Nov 25, 2018

DeepCode analyzed this pull request.
There are 2 new info reports.

Click to see more details.

@p0psicles
* Fixed getting recommended shows from Imdb
488f80b 
* Fixed isotope using vueisotope.
* Added db columns image_src and mapped_series_id.
* Moved the save_to_db to the for loop. Making it save after each show. And not wait until all shows have been parsed.
* Fixed store.
@ghost
Copy link

ghost commented Nov 26, 2018

DeepCode analyzed this pull request.
There are 3 new info reports.

Click to see more details.

@OmgImAlexis OmgImAlexis requested review from OmgImAlexis and medariox and removed request for OmgImAlexis November 26, 2018 20:59
OmgImAlexis
OmgImAlexis reviewed Nov 26, 2018
View reviewed changes
Copy link
Collaborator

@OmgImAlexis OmgImAlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good.

themes-default/slim/src/store/modules/recommended.js Outdated Show resolved Hide resolved
@OmgImAlexis OmgImAlexis added Needs testing Requires testing to make sure it's working as intended Needs test (Vue) Needs tests added for this change (Vue) labels Nov 26, 2018
@p0psicles
Changed recommended store.
7b06255
@p0psicles
Created a generic update queue, as a thread that can be used
3c7545d 
as a more all purpose queuing thread.
* Created a queue item for recommended lists updating.
* Queue the recommended show updates from the show_updater.
@pymedusa pymedusa deleted a comment Dec 8, 2018
@p0psicles
Added basic functionality of adding a show, from recommended show.
1992f7d 
* Added new store method addShow.
* Added selectedShowOptions options to addShows_recommended_vue.mako
@ghost
Copy link

ghost commented Dec 16, 2018

DeepCode analyzed this pull request.
There are 2 new info reports.

Click to see more details.

@p0psicles
Merge remote-tracking branch 'remotes/origin/develop' into feature/re…
be2680d 
…c-show-v2

# Conflicts:
#	medusa/scene_numbering.py
#	themes-default/slim/src/store/index.js
#	themes-default/slim/yarn.lock
#	themes/dark/assets/js/medusa-runtime.js
#	themes/light/assets/js/medusa-runtime.js
@p0psicles
Fix set local vue variable selectedShowOptions from the add-show-opti…
4781832 
…ons component.
@ghost
Copy link

ghost commented Dec 16, 2018

DeepCode analyzed this pull request.
There are 2 new info reports.

Click to see more details.

@p0psicles
Merge remote-tracking branch 'origin/develop' into feature/rec-show-v2
5410a87 
# Conflicts:
#	medusa/server/web/home/add_shows.py
#	medusa/show/recommendations/anidb.py
#	medusa/show/recommendations/recommended.py
#	medusa/show/recommendations/trakt.py
@ghost
Copy link

ghost commented Dec 23, 2018

DeepCode analyzed this pull request.
There are 2 new info reports.

Click to see more details.

@p0psicles
Add genres.
e3493de
@p0psicles
also disable list select.
c99edd4
@p0psicles
restore check-overlay
cc5c173
@p0psicles
Clean up empty genres for anidb.
19c1d18
@p0psicles
Add save button, so you can enable trakt from the component.
665c620
@p0psicles
Remove myanimelist references
a3eeed6
@p0psicles
mvt adba
e1bf0ff 
Added ttl_cache
@p0psicles
Added plot information to recommended shows.
261d70d
@p0psicles
Moved recommended shows to dedicated database.
ff484d3
@p0psicles
one to many underscore
9b18c3f
@p0psicles
fix lint
71993f7
@p0psicles
fix pytest
f637e2c
@p0psicles
pylint
e514ab8
@p0psicles
Fix lint issue
fa53e86
@p0psicles
Merge remote-tracking branch 'origin/develop' into feature/rec-show-v2
9708559
@p0psicles
Yarn dev
f9f8f3d
@p0psicles
Remove unused mako.
2b3dd16
@p0psicles
Merge branch 'feature/rec-show-v2' of https://github.com/pymedusa/Medusa
c65bdbd 
 into feature/rec-show-v2
@p0psicles
Remove more unused mako.
b207ff3
@p0psicles
Merge remote-tracking branch 'origin/develop' into feature/rec-show-v2
2e9421d 
# Conflicts:
#	medusa/helper/exceptions.py
@p0psicles
Update changelog
714c70b
@p0psicles
update changelog
27a6220
@p0psicles
build runtime
9a19f1c
@p0psicles
update changelog
ce0759a
@p0psicles
Fix jest tests (snapshots)
34bd96c
@p0psicles
Merge branch 'feature/rec-show-v2' of https://github.com/pymedusa/Medusa
6d04afc 
 into feature/rec-show-v2
@p0psicles
Don't comment, but xit test.
5567c23
@p0psicles
use it.skip in stead
306a5fd
@p0psicles p0psicles merged commit 1816b75 into develop Aug 7, 2021
@p0psicles p0psicles deleted the feature/rec-show-v2 branch August 7, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmgImAlexis OmgImAlexis OmgImAlexis left review comments

@medariox medariox Awaiting requested review from medariox

Assignees
No one assigned
Labels
Needs test (Vue) Needs tests added for this change (Vue) Needs testing Requires testing to make sure it's working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@p0psicles @jeffski10 @OmgImAlexis