Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AppLink to enable native mouse navigation #7498

Merged
merged 2 commits into from Dec 15, 2019

Conversation

sharkykh
Copy link
Contributor

Add a href attribute to enable native mouse navigation (middle click, ctrl+click, etc.)
(This is for when AppLink is a RouterLink, it's annoying that you can't open it in a new tab)

Add a `href` attribute to enable native mouse navigation (middle click, ctrl+click, etc.)
@p0psicles p0psicles merged commit 9ef093b into develop Dec 15, 2019
@p0psicles p0psicles deleted the feature/app-link-native-mouse-nav branch December 15, 2019 16:49
@OmgImAlexis
Copy link
Collaborator

OmgImAlexis commented Dec 19, 2019

Looks like this broke manual searching. Links as such no longer send a background request, instead the link is followed. This link is from the schedule page btw.

http://192.168.1.21:8081/home/searchEpisode?indexername=tvdb&seriesid=351134&season=2&episode=3

to: matchingVueRoute.fullPath
to: matchingVueRoute.fullPath,
// Add a `href` attribute to enable native mouse navigation (middle click, ctrl+click, etc.)
href: new URL(matchingVueRoute.fullPath, base).href
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely needed to be moved down to the below block, if it's added here it'll need to have some kind of check since not all AppLink components should be openable in another tab.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well currently it only affects converted pages' links to other converted pages (like config-general to config). It's possible there's an edge case I missed.

@sharkykh
Copy link
Contributor Author

sharkykh commented Dec 19, 2019

It was already reported before this got merged #7462 so I don't think that this change caused that. Haven't had time to check though.

Edit: Try running $.ajaxEpSearch() in console, it fixes the link for me..
It's probably the JS running before the page is fully rendered by Vue...

Edit 2: Fixed with #7512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants