Fix not download new quality after quality change

[fernandog]

as discussed in slack

Wanted quality is HD720P . and i have a SDTV when my show had SDTV wanted quality

From logs:
Episode already exists with quality SDTV and the found result has same/lower quality, ignoring found result for Ripper Street S04E03 with quality 720p WEB-DL

medusa ignored 720p result

[fernandog]

@ratoaq2 @medariox need to review all the tests.

If you have qualities in the Preferred list set, any episode matching a quality in this list will not be replaced with a better quality. AKA it is a "best" match and is final.

If you ONLY have qualities in the Allowed list (Or have a preset selected other than custom) it will also stop on the first match in this list and be considered a "best" match, and never be replaced with a better quality.

If you have qualities in BOTH lists, it will accept any quality in the Allowed list, and continue looking for a better quality in the Allowed list, until it finds one in the Preferred list.

[fernandog]

Need to see if this needed to be changed also:
https://github.com/pymedusa/SickRage/blob/develop/sickbeard/search.py#L313

https://github.com/pymedusa/Medusa/blob/develop/medusa/search/core.py#L323

[fernandog]

This one is reladed to backlog overview

All logic should be in one place only right?
https://github.com/pymedusa/SickRage/blob/develop/sickbeard/tv.py#L1574

https://github.com/pymedusa/Medusa/blob/develop/medusa/tv.py#L1692-L1730

[fernandog]

@medariox milestone 0.1.5 right? we need make sure this works fine (keep some days in develop)

[fernandog]

My review about tests is missing? what happened?

need to add tests with status ARCHIVED and status UNKNOWN

[fernandog]

@ratoaq2 @medariox there is too place that still does some quality checks:

https://github.com/pymedusa/Medusa/blob/develop/medusa/search/core.py#L323
https://github.com/pymedusa/Medusa/blob/develop/medusa/tv.py#L1692-L1730

all logic should be in one place right?

[NicoLeOca]

@fernandog
not sure it is ok for me to remind it here but:
can you please have a look to the fact that a manual snatch is directly considered as being of the prefered quality no matter what the exact quality is?
#872

the interest clearly depends on the ETA of this:
#1266
and if you really review it completely as @OmgImAlexis and I suggested.

[medariox]

Here is how it works

If you only have qualities in the Allowed list set (or have a preset selected other than custom), any episode matching a quality in this list will not be replaced with a better quality - it will stop at the first quality found. [unchanged behavior]

If you only have qualities in the Preferred list set it will accept any quality in the Preferred list, and continue looking for a better quality in the Preferred list until the highest quality is found. [changed behavior - previously it would be like "only qualities in Allowed list"]

If you have qualities in both lists, it will accept any quality in the Preferred or Allowed list, and continue looking for a better quality in the Allowed list, until it finds one in the Preferred list [unchanged behavior - logic is inverted here compared to 1st and 2nd scenario]

[fernandog]

@medariox today this "If you only have qualities in the Preferred list set" is in allowed. are we changing it? users will need to change their quality settings?

[NicoLeOca]

@medariox
I didn't know that
that's a very good news then

Cheers

[medariox]

@fernandog
Users that have custom preset with only allowed qualities set will eventually need to change that to preferred qualities, in order to keep the same behavior.

[ratoaq2]

Just need to invert the logic in the method and its test

[fernandog]

superseeded

[NicoLeOca]

@medariox @ratoaq2 @fernandog
Guys,
can you please add the explanations of how to handle quality settings somewhere easy to find for everyone?
like next to the settings

cause I use Medusa/SR for some time now and I just learned that if there are several prefered qualities setup, they will be downloaded successively up to the best.