Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the remove_strings into the remove_non_release_groups() function #559

Merged
merged 1 commit into from
May 9, 2016

Conversation

p0psicles
Copy link
Contributor

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Always make sure the PR has a clear description of why,how, and what your trying to fix. The same goes for improvements or new features. Also if you refering to an issue, make sure a summary is available in the PR.
  • Read contribution guide

Improving maintainability. Made it optional using args.
Removed all the camelCase vars, where possible from properFinder.py.

…n. Improving maintainability. Made it optional using args.

Removed all the camelCase vars, where possible.
@fernandog
Copy link
Contributor

fernandog commented May 9, 2016

Approved

Approved with PullApprove

@fernandog fernandog merged this pull request into multi_proper May 9, 2016
@fernandog fernandog deleted the multi_proper_pep8 branch May 9, 2016 13:59
fernandog pushed a commit that referenced this pull request May 11, 2016
…n. Improving maintainability. Made it optional using args. (#559)

Removed all the camelCase vars, where possible.
p0psicles pushed a commit that referenced this pull request May 13, 2016
* Fix snatch same proper over and over
* Moved the remove_strings into the remove_non_release_groups() function. Improving maintainability. Made it optional using args. (#559)
* Removed all the camelCase vars, where possible.
* Added "[req] " as prefix that needs to be removed in removewords.
* Moved the [REQ] to non_release_names
@p0psicles
Copy link
Contributor Author

#392

p0psicles pushed a commit that referenced this pull request Jun 21, 2016
* Fix snatch same proper over and over
* Moved the remove_strings into the remove_non_release_groups() function. Improving maintainability. Made it optional using args. (#559)
* Removed all the camelCase vars, where possible.
* Added "[req] " as prefix that needs to be removed in removewords.
* Moved the [REQ] to non_release_names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants