Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ The road to RC ] Todo's #392

Closed
16 tasks done
p0psicles opened this issue Apr 15, 2016 · 8 comments
Closed
16 tasks done

[ The road to RC ] Todo's #392

p0psicles opened this issue Apr 15, 2016 · 8 comments

Comments

@p0psicles
Copy link
Contributor

p0psicles commented Apr 15, 2016

This list will be used as a roadmap towards RC and later the merge to Master.
The list is meant for finishing already started features or bugfixes.

General

  • Bump Database version

Manual Search

General bugs

Subliminal

  • Limit the amount of "2016-04-15 10:18:22 DEBUG FINDSUBTITLES :: [1f87e70] Found subtitle" messages. Found subtitle isn't really "informative". @ratoaq2
  • Improve performance or throttle subtitleFinder thread cpu usage. As a search is bringing my dualcore Atom on it knees. Wonder what it will do to a low end arm device. Give the CPU a break while searching for subs #472

@pymedusa/contributors

@labrys
Copy link
Contributor

labrys commented Apr 16, 2016

You don't need to query the full history, just the history for that particular episode. The idea is to know which releases have already been snatched in the past so the user doesn't try the same one again. More specifically you only need to query for snatched/downloaded statuses in the history.

@fernandog
Copy link
Contributor

@p0psicles need only one fix for manual search
main thread updated

@p0psicles
Copy link
Contributor Author

p0psicles commented Apr 22, 2016

Yeah and we still need allot of bugfixes before we can start moving to RC1.

Also personal note! Need to send mail to contact@anizb.org with requests to add us as a compatible client, when we merge to master.

@OmgImAlexis
Copy link
Collaborator

OmgImAlexis commented Apr 23, 2016

If anyone needs access to our pymedusa.com email let me know as I have it setup. It'll look a little better to use that instead of a personal email.

@p0psicles
Copy link
Contributor Author

If we focus on this list from now, we're very close to release: https://github.com/pymedusa/SickRage/milestones/RC1
But then we should lay low on the "improvements" and definitely stop working on new features.

@pymedusa/developers What do you guys think?

@ratoaq2
Copy link
Contributor

ratoaq2 commented May 14, 2016

Related to:

Limit the amount of "2016-04-15 10:18:22 DEBUG FINDSUBTITLES :: [1f87e70] Found subtitle" messages. Found subtitle isn't really "informative". @ratoaq2

This is what subliminal will log::
https://github.com/Diaoul/subliminal/blob/develop/subliminal/providers/legendastv.py#L426
https://github.com/Diaoul/subliminal/blob/develop/subliminal/providers/legendastv.py#L94
Found subtitle <%s [%s] %r>' % (self.__class__.__name__, self.id, self.name)

The issue is that the web page that shows the logs doesn't escape the log and the information between <and > is not displayed. What is the expectation here? To fix it and display the correct log message with all characters and information or to suppress it?

@labrys
Copy link
Contributor

labrys commented May 14, 2016

@ratoaq2 I would think try displaying. If we find that's still too verbose we can suppress it. Either imo would be better than an uninformative message.

@p0psicles p0psicles modified the milestones: RC1, 0.1.0 May 19, 2016
@labrys labrys mentioned this issue May 19, 2016
4 tasks
@labrys
Copy link
Contributor

labrys commented May 20, 2016

Closing this as release to v0.1.0rc1 complete. If no issues present in the next couple days lets RTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants