Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimenting: pytest flake8 #836

Merged
merged 3 commits into from
Jul 31, 2016
Merged

Experimenting: pytest flake8 #836

merged 3 commits into from
Jul 31, 2016

Conversation

ratoaq2
Copy link
Contributor

@ratoaq2 ratoaq2 commented Jul 29, 2016 •
edited

  • PEP8 checks
  • PEP257 checks
  • cryptography import order style
  • py.test (tests/test_subtitles.py is a reference implementation)

@ratoaq2 ratoaq2 mentioned this pull request Jul 29, 2016
Merged
3 tasks
@fernandog
Copy link
Contributor

@ratoaq2 concluded or in progress?

@ratoaq2 ratoaq2 self-assigned this Jul 30, 2016
@ratoaq2
Copy link
Contributor Author

ratoaq2 commented Jul 30, 2016 •
edited

This is a proposal. If everyone agrees with it then it's completed.

@medariox
Copy link
Contributor

I like and agree!

@medariox
Copy link
Contributor

medariox commented Jul 31, 2016 •
edited

Approved

Approved with PullApprove

@fernandog fernandog merged commit 6531126 into develop Jul 31, 2016
@fernandog fernandog deleted the pytest_flake8 branch July 31, 2016 16:53
@fernandog fernandog added this to the 0.1.3 milestone Jul 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ratoaq2 ratoaq2

Labels
Concluded Discussion
Projects
None yet
Milestone
0.1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ratoaq2 @fernandog @medariox