-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add superqt QCollapsibles to the gui #107
Conversation
Codecov Report
@@ Coverage Diff @@
## main #107 +/- ##
==========================================
+ Coverage 74.37% 74.77% +0.39%
==========================================
Files 17 19 +2
Lines 1686 1748 +62
==========================================
+ Hits 1254 1307 +53
- Misses 432 441 +9
Continue to review full report at Codecov.
|
looks great. I think we should now remove the group boxes around each of the Objectives, shutters, and camera ROI. let's get #90 in though so you don't need to worry about conflicts, then we'll come back to this |
for more information, see https://pre-commit.ci
@fdrgsp ... I tried to merge main into this, but it has become a big merge mess now. this is one reason I tried to emphasize that the qcollapsible should come after we merged #90 :). Because this PR was branched off of that PR, we pretty much couldn't do anything to that one without screwing up this one. If it were me, I'd probably just create a new branch from main, and redo whatever you had done here. But I'll leave it up to you. try to get the diff back down to as small of a change as needed to implement what you wanted to do here |
@tlambert03 Sure, no problem! I'll let you know when it is fixed 👍🏻 Thanks! |
@tlambert03 I think this is now ready! Let's wait for the tests (locally they all pass) and then you can probably merge. |
does ~1,100 added and 995 lines removed sound right for this? Why is this such a big change to add a qcollapsible? |
I think this is just because all the single widgets are a different the before. |
ok thanks. I like the new layout, and tests are passing, so I'm going to merge. But will follow up with some stylistic refactors and simplifications, and will ping you |
Liked to PR #90 and issue #106.
This PR should be merged after #90.
This PR adds superqt QCollapsibles to the gui.
Compared to #90, I removed the camera
bit depth
andbinning
controls since I figured that we can set it through theproperty browser
and we will be able to control it through thegroup and preset table
(once ready).I also added the
shutter
widget in the gui (since I want to open a PR to implement shutters control).720p_coll.mov